Skip to content

[ROCm] Fix DeepSeek R1/V3 incorrect output in eager mode. #27392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Duyi-Wang wants to merge 1 commit into from
Closed

[ROCm] Fix DeepSeek R1/V3 incorrect output in eager mode. #27392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vllm/model_executor/layers/rotary_embedding/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ def forward_hip(
else:
# ops.rotary_embedding() is an in-place operation
# that updates the query and key tensors.
Comment on lines 169 to 170
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

These comments state that an internal operation is in-place, which contradicts the FIXME on the next line and the logic of the fix (which treats forward_cuda as not in-place by using its return value). To avoid confusion for future readers and maintainers, it would be better to remove these now-misleading comments.

self.forward_cuda(positions, query, key)
# FIXME: self.forward_cuda is not a in-place operation in eager mode.
return self.forward_cuda(positions, query, key)
return query, key

def forward_xpu(
Expand Down