Skip to content

[Model] Add shared_head to prefix of SharedHead. #27193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whx-sjtu wants to merge 1 commit into from
Closed

[Model] Add shared_head to prefix of SharedHead. #27193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vllm/model_executor/models/deepseek_mtp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ def __init__(self, vllm_config: VllmConfig, prefix: str) -> None:
topk_indices_buffer = None

self.shared_head = SharedHead(
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While the change to add a prefix is correct, I've noticed that the SharedHead class is duplicated. An identical implementation exists in vllm/model_executor/models/glm4_moe_mtp.py. To adhere to the DRY (Don't Repeat Yourself) principle and improve long-term maintainability, this class should be defined in a single, shared location, such as vllm/model_executor/models/utils.py, and then imported where needed. This would prevent future inconsistencies and simplify changes like the one in this PR, as it would only need to be applied once.

config=config, prefix=prefix, quant_config=quant_config
config=config,
prefix=maybe_prefix(prefix, "shared_head"),
quant_config=quant_config,
)
self.mtp_block = DeepseekV2DecoderLayer(
vllm_config,
Expand Down
4 changes: 3 additions & 1 deletion vllm/model_executor/models/glm4_moe_mtp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ def __init__(
self.hnorm = RMSNorm(config.hidden_size, eps=config.rms_norm_eps)
self.eh_proj = nn.Linear(config.hidden_size * 2, config.hidden_size, bias=False)
self.shared_head = SharedHead(
config=config, prefix=prefix, quant_config=quant_config
config=config,
prefix=maybe_prefix(prefix, "shared_head"),
quant_config=quant_config,
)
self.mtp_block = Glm4MoeDecoderLayer(
config=config,
Expand Down
Loading