[Chore]:Extract math and argparse utilities to separate modules#27188
Merged
vllm-bot merged 14 commits intovllm-project:mainfrom Oct 26, 2025
Merged
[Chore]:Extract math and argparse utilities to separate modules#27188vllm-bot merged 14 commits intovllm-project:mainfrom
vllm-bot merged 14 commits intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors math and argparse utilities into separate modules, which is a great step for improving code organization and maintainability. The changes correctly maintain backward compatibility by re-exporting the moved utilities. My review focuses on the newly created files, where I've identified a few issues: a missing type hint that could lead to a runtime error, a leftover debug print statement, and a couple of instances of incorrect string formatting for error and log messages. These issues could impact usability and debugging. I've provided specific suggestions to address them.
vllm/utils/__init__.py
Outdated
|
|
||
| def round_down(x: int, y: int) -> int: | ||
| return (x // y) * y | ||
| # Math utilities - imported from math_utils module |
Member
There was a problem hiding this comment.
Let's update vLLM code to use the new module-specific imports
yeshsurya
requested review from
22quinn,
ApostaC,
LucasWilkinson,
NickLucche,
ProExpertProg,
WoosukKwon,
aarnphm,
alexm-redhat,
chaunceyjiang,
comaniac,
gshtras,
heheda12345,
mgoin,
njhill,
noooop,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256,
youkaichao,
ywang96 and
zou3519
as code owners
|
Documentation preview: https://vllm--27188.org.readthedocs.build/en/27188/ |
mergify
bot
added
documentation
Fixed syntax error where an incomplete 'from vllm.utils import ('
statement was left in the file, causing compilation failures.
Signed-off-by: Yeshwanth Surya <yeshsurya@gmail.com>
- Remove unused imports from vllm/utils/__init__.py (argparse, collections, regex) - Add missing 'cache' import from functools - Fix duplicate imports in multiple files causing F811 redefinition errors: - tests/kernels/attention/test_deepgemm_attention.py - vllm/model_executor/layers/fused_moe/config.py - vllm/model_executor/layers/fused_moe/layer.py - vllm/v1/attention/backends/flashinfer.py - vllm/v1/worker/tpu_model_runner.py All imports now use the specific module paths (e.g., vllm.utils.math_utils) instead of importing from vllm.utils directly. Signed-off-by: Yeshwanth Surya <yeshsurya@gmail.com>
yeshsurya
force-pushed
the
feature/extract-argparse-utils
branch
from
5a024f8 to
9b5a5fc
Compare
Fixed import ordering in three files to comply with ruff's isort rules: - vllm/entrypoints/utils.py: Reordered transformers_utils before utils imports - vllm/utils/__init__.py: Moved platform_utils after specialized module imports - vllm/utils/deep_gemm.py: Reordered import_utils before math_utils These changes resolve the ruff-check failures in the pre-commit hooks. Signed-off-by: yeshsurya <yeshsurya@gmail.com>
yeshsurya
force-pushed
the
feature/extract-argparse-utils
branch
from
ef0d520 to
92535f8
Compare
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by extracting math and argparse utilities into separate modules, vllm/utils/math_utils.py and vllm/utils/argparse_utils.py respectively. This is a good improvement for code organization and maintainability. The changes are well-executed, with imports updated across the codebase and backward compatibility maintained through re-exports in vllm/utils/__init__.py. I have reviewed the changes and found no issues. The refactoring is clean and a positive step for the project's structure.
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
1 task
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
…-project#27188) Signed-off-by: Yeshwanth Surya <yeshsurya@gmail.com> Signed-off-by: Yeshwanth N <yeshsurya@gmail.com> Signed-off-by: yeshsurya <yeshsurya@gmail.com>
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…-project#27188) Signed-off-by: Yeshwanth Surya <yeshsurya@gmail.com> Signed-off-by: Yeshwanth N <yeshsurya@gmail.com> Signed-off-by: yeshsurya <yeshsurya@gmail.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…-project#27188) Signed-off-by: Yeshwanth Surya <yeshsurya@gmail.com> Signed-off-by: Yeshwanth N <yeshsurya@gmail.com> Signed-off-by: yeshsurya <yeshsurya@gmail.com>
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Nov 12, 2025
### What this PR does / why we need it? adapt vllm-ascend main branch with vllm releases/v0.11.1 fix `forward context not set` in test_vlm.py caused by: vllm-project/vllm#23207 fix import `cdiv round` failed caused by: vllm-project/vllm#27188 fix import `init_cached_hf_modules` failed caused by: vllm-project/vllm#27567 adapt triton kernel `fused_recurrent_gated_delta_rule_fwd_kernel` caused by: vllm-project/vllm#27654 - remove unused code in sigmoid_gating.py - `class FusedRecurrentFunction` , `fused_recurrent_gated_delta_rule`, `fused_recurrent_gated_delta_rule_fwd` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: 22dimensions <waitingwind@foxmail.com>
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? adapt vllm-ascend main branch with vllm releases/v0.11.1 fix `forward context not set` in test_vlm.py caused by: vllm-project/vllm#23207 fix import `cdiv round` failed caused by: vllm-project/vllm#27188 fix import `init_cached_hf_modules` failed caused by: vllm-project/vllm#27567 adapt triton kernel `fused_recurrent_gated_delta_rule_fwd_kernel` caused by: vllm-project/vllm#27654 - remove unused code in sigmoid_gating.py - `class FusedRecurrentFunction` , `fused_recurrent_gated_delta_rule`, `fused_recurrent_gated_delta_rule_fwd` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: 22dimensions <waitingwind@foxmail.com> Signed-off-by: luolun <luolun1995@cmbchina.com>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? adapt vllm-ascend main branch with vllm releases/v0.11.1 fix `forward context not set` in test_vlm.py caused by: vllm-project/vllm#23207 fix import `cdiv round` failed caused by: vllm-project/vllm#27188 fix import `init_cached_hf_modules` failed caused by: vllm-project/vllm#27567 adapt triton kernel `fused_recurrent_gated_delta_rule_fwd_kernel` caused by: vllm-project/vllm#27654 - remove unused code in sigmoid_gating.py - `class FusedRecurrentFunction` , `fused_recurrent_gated_delta_rule`, `fused_recurrent_gated_delta_rule_fwd` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: 22dimensions <waitingwind@foxmail.com> Signed-off-by: hwhaokun <haokun0405@163.com>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
### What this PR does / why we need it? adapt vllm-ascend main branch with vllm releases/v0.11.1 fix `forward context not set` in test_vlm.py caused by: vllm-project/vllm#23207 fix import `cdiv round` failed caused by: vllm-project/vllm#27188 fix import `init_cached_hf_modules` failed caused by: vllm-project/vllm#27567 adapt triton kernel `fused_recurrent_gated_delta_rule_fwd_kernel` caused by: vllm-project/vllm#27654 - remove unused code in sigmoid_gating.py - `class FusedRecurrentFunction` , `fused_recurrent_gated_delta_rule`, `fused_recurrent_gated_delta_rule_fwd` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: 22dimensions <waitingwind@foxmail.com> Signed-off-by: nsdie <yeyifan@huawei.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…-project#27188) Signed-off-by: Yeshwanth Surya <yeshsurya@gmail.com> Signed-off-by: Yeshwanth N <yeshsurya@gmail.com> Signed-off-by: yeshsurya <yeshsurya@gmail.com>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 10, 2025
### What this PR does / why we need it? adapt vllm-ascend main branch with vllm releases/v0.11.1 fix `forward context not set` in test_vlm.py caused by: vllm-project/vllm#23207 fix import `cdiv round` failed caused by: vllm-project/vllm#27188 fix import `init_cached_hf_modules` failed caused by: vllm-project/vllm#27567 adapt triton kernel `fused_recurrent_gated_delta_rule_fwd_kernel` caused by: vllm-project/vllm#27654 - remove unused code in sigmoid_gating.py - `class FusedRecurrentFunction` , `fused_recurrent_gated_delta_rule`, `fused_recurrent_gated_delta_rule_fwd` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: 22dimensions <waitingwind@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Contributes to #26900
Test Plan
Verify that the refactoring of math and argparse utilities into separate modules (vllm/utils/math_utils.py and vllm/utils/argparse_utils.py)
maintains backward compatibility and does not break existing functionality
Test Result
tests/utils_/test_utils.py
Passed
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.