Skip to content

expand coverage of gpt2 models#271

Merged
zhuohan123 merged 1 commit intovllm-project:mainfrom
twaka:main
Jun 27, 2023
Merged

expand coverage of gpt2 models#271
zhuohan123 merged 1 commit intovllm-project:mainfrom
twaka:main

Conversation

@twaka
Copy link
Copy Markdown
Contributor

@twaka twaka commented Jun 27, 2023

Thanks for the amazing project!
I noticed some gpt2 models have different naming of weights from https://huggingface.co/gpt2

For example, DialoGPT-small and mGPT are saved in a way that transformer. prefix is already prepended and also masked_bias is saved.

transformer.wte.weight
transformer.wpe.weight
transformer.h.0.attn.c_attn.weight
transformer.h.0.attn.c_attn.bias
transformer.h.0.attn.bias
transformer.h.0.attn.masked_bias
...

Therefore, it causes errors such asKeyError: 'transformer.transformer.wte.weight'.
This PR fixes these errors in model loading by checking transformer. prefix and ignoring masked_bias.

Copy link
Copy Markdown
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@zhuohan123 zhuohan123 merged commit 4026a04 into vllm-project:main Jun 27, 2023
michaelfeil pushed a commit to michaelfeil/vllm that referenced this pull request Jul 1, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
yukavio pushed a commit to yukavio/vllm that referenced this pull request Jul 3, 2024
includes the NOTICE file alongside the license files in the
nm-vllm*.dist-info directory
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Sep 24, 2024
Attn MetaData was hard coded to bfloat16, leading to a runtime error for
float32 model instantiation.
mht-sharma pushed a commit to mht-sharma/vllm that referenced this pull request Dec 9, 2024
use_beam_search is no longer in sampling params
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
### What this PR does / why we need it?
Re-arch on tutorials, move singe npu / multi npu / multi node to index.
- Unifiy docker run cmd
- Use dropdown to hide build from source installation doc
- Re-arch tutorials to include Qwen/QwQ/DeepSeek
- Make QwQ doc works

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI test



Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
amy-why-3459 pushed a commit to amy-why-3459/vllm that referenced this pull request Sep 15, 2025
### What this PR does / why we need it?
Re-arch on tutorials, move singe npu / multi npu / multi node to index.
- Unifiy docker run cmd
- Use dropdown to hide build from source installation doc
- Re-arch tutorials to include Qwen/QwQ/DeepSeek
- Make QwQ doc works

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI test



Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants