Skip to content

Add more verbose error for missing CUDA_HOME#269

Closed
neubig wants to merge 1 commit intovllm-project:mainfrom
neubig:more_verbose_error_for_cuda_home
Closed

Add more verbose error for missing CUDA_HOME#269
neubig wants to merge 1 commit intovllm-project:mainfrom
neubig:more_verbose_error_for_cuda_home

Conversation

@neubig
Copy link
Copy Markdown
Contributor

@neubig neubig commented Jun 27, 2023

Currently, if installation is run in an environment where CUDA_HOME is not set, it dies with a rather opaque error. This PR adds an additional check to explain the root cause of the problem.

Before:

$ pip install -e .
Obtaining file:////home/gneubig/work/vllm
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Traceback (most recent call last):
        File "/home/gneubig/anaconda3/envs/vllm/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/gneubig/anaconda3/envs/vllm/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/gneubig/anaconda3/envs/vllm/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 132, in get_requires_for_build_editable
          return hook(config_settings)
        File "/tmp/pip-build-env-x2q5xdsw/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 450, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
        File "/tmp/pip-build-env-x2q5xdsw/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 341, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-x2q5xdsw/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 323, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-x2q5xdsw/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 338, in run_setup
          exec(code, locals())
        File "<string>", line 59, in <module>
        File "<string>", line 34, in get_nvcc_cuda_version
      TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

After:

$ pip install -e .
Obtaining file:///home/gneubig/work/vllm
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [17 lines of output]
      Traceback (most recent call last):
        File "/home/gneubig/anaconda3/envs/vllm/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/gneubig/anaconda3/envs/vllm/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/gneubig/anaconda3/envs/vllm/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 132, in get_requires_for_build_editable
          return hook(config_settings)
        File "/tmp/pip-build-env-nduv0z00/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 450, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
        File "/tmp/pip-build-env-nduv0z00/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 341, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-nduv0z00/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 323, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-nduv0z00/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 338, in run_setup
          exec(code, locals())
        File "<string>", line 60, in <module>
      ValueError: Could not find CUDA_HOME variable, please check your CUDA installation.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

@zhuohan123 zhuohan123 requested a review from WoosukKwon June 27, 2023 13:15
Copy link
Copy Markdown
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Maybe you can merge the logic in this PR with this part in setup.py?

@zhuohan123
Copy link
Copy Markdown
Member

I'll close this PR since #282 is a better fix. However, thanks for the work and I added you as a co-author of PR #282 for working on this issue.

@zhuohan123 zhuohan123 closed this Jun 27, 2023
@neubig
Copy link
Copy Markdown
Contributor Author

neubig commented Jun 28, 2023

Thanks @zhuohan123! Happy to have the problem fixed regardless

jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Sep 24, 2024
Fix blocks number calculation for Flat PA via adding empty table_block
(HabanaAI#158)
mht-sharma pushed a commit to mht-sharma/vllm that referenced this pull request Dec 9, 2024
* Added build arg for RPD build to disable it until its build is fixed for ROCm6.3

* Passing the arg to the final stage
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
### What this PR does / why we need it?
Update code block

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed, preview

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Jul 31, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
yma11 pushed a commit to yma11/vllm that referenced this pull request Sep 1, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
zhenwei-intel pushed a commit to zhenwei-intel/vllm that referenced this pull request Sep 11, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
yma11 pushed a commit to yma11/vllm that referenced this pull request Sep 15, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
yma11 pushed a commit to yma11/vllm that referenced this pull request Nov 3, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
yma11 pushed a commit to yma11/vllm that referenced this pull request Nov 16, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
yma11 pushed a commit to yma11/vllm that referenced this pull request Nov 19, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request Dec 11, 2025
- Dockerfile.rocm.ubi: add aiter dependencies, keep disabled aiter by
default
- Dockerfile*.ubi: fix tiktoken patch step (upstream:
openai/tiktoken#446)
- docker-bake: add note about `ROCM_VERSION` variable
- Dockerfile.rocm.ubi: remove deprecated
`VLLM_WHEEL_STRATEGY`/`FLASH_ATTENTION_WHEEL_STRATEGY` args
yma11 pushed a commit to yma11/vllm that referenced this pull request Dec 30, 2025
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
cursor Bot pushed a commit to Shirley125/vllm_epd that referenced this pull request Jan 22, 2026
Signed-off-by: hsliu <liuhongsheng4@huawei.com>
yma11 pushed a commit to yma11/vllm that referenced this pull request Jan 27, 2026
* add ci workflow files

* 1

* 1

* add docker prune for building

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* 1

* add cache clean

* add cache clean

* add cache clean

* add cache clean

* only for release branch enable

* fix results upload

* 1

* fix proxy

* 1

* change proxy for bmg
mickg10 pushed a commit to mickg10/vllm that referenced this pull request Feb 11, 2026
Signed-off-by: Salar <skhorasgani@tenstorrent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants