Skip to content

chore: remove unused marker#26890

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
siemens:chore-remove-unused-marker
Oct 15, 2025
Merged

chore: remove unused marker#26890
vllm-bot merged 1 commit intovllm-project:mainfrom
siemens:chore-remove-unused-marker

Conversation

@max-wittig
Copy link
Copy Markdown
Contributor

@max-wittig max-wittig commented Oct 15, 2025

This was introduced by accident in #20983

@NickLucche

/cc @antoineauger

Purpose

Remove marker that was introduced by accident

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

This was introduced by accident in vllm-project#20983.
Sorry about that.

Signed-off-by: Max Wittig <max.wittig@siemens.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an unused pytest marker, extra_server_args, from the pyproject.toml configuration file. I've verified that this marker is not referenced in any of the provided code, confirming that its removal is safe and serves as good code hygiene. The change is correct and improves the project's configuration clarity.

@vllm-bot vllm-bot merged commit 5d59868 into vllm-project:main Oct 15, 2025
8 checks passed
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
@max-wittig max-wittig deleted the chore-remove-unused-marker branch October 16, 2025 06:24
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: Max Wittig <max.wittig@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants