[BugFix] Patch inductor memory plan logic#26878
Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom Oct 15, 2025
Merged
[BugFix] Patch inductor memory plan logic#26878DarkLight1337 merged 5 commits intovllm-project:mainfrom
DarkLight1337 merged 5 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Boyuan Feng <boyuan@meta.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a monkey patch for a PyTorch 2.9.0 issue related to inductor's memory planning, which was causing test_multi_graph_piecewise_compile to fail. The patch is applied conditionally for PyTorch 2.9.0. The changes also include enabling the failing test for PyTorch versions 2.9.0.dev and newer, assuming the fix is present in those versions. While the overall approach is sound for a temporary workaround, I've found a critical issue in the version comparison logic that could lead to the patch being applied to incorrect PyTorch versions.
ProExpertProg
approved these changes
Oct 15, 2025
ProExpertProg
added a commit
to neuralmagic/vllm
that referenced
this pull request
Oct 15, 2025
commit 6b0c3c3 Author: Boyuan Feng <boyuan@meta.com> Date: Tue Oct 14 21:30:29 2025 -0700 nit Signed-off-by: Boyuan Feng <boyuan@meta.com> commit 1016467 Author: Boyuan Feng <boyuan@meta.com> Date: Tue Oct 14 21:21:47 2025 -0700 fix multi-graph test Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: ProExpertProg <lgovedic@redhat.com>
ProExpertProg
added this to the
vllm==v0.12.0/torch==2.9.0 compilation improvements milestone
ProExpertProg
added
the
ready
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Boyuan Feng <boyuan@meta.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Documentation preview: https://vllm--26878.org.readthedocs.build/en/26878/ |
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: bbartels <benjamin@bartels.dev>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
1 task
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test failure for
test_multi_graph_piecewise_compile. This is a pytorch issue and is fixed in pytorch/pytorch#165514. This PR monkey patches vLLM for PyTorch-2.9.0 only to unblock.