[Docs] Move build.inc into arm.inc#26862
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Oct 15, 2025
Merged
Conversation
|
Documentation preview: https://vllm--26862.org.readthedocs.build/en/26862/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the documentation by moving build instructions from build.inc.md into arm.inc.md and deleting the now-redundant file. This is a good cleanup. My review identifies that the build instructions for ARM are using deprecated setup.py commands. I have suggested updating them to use modern uv pip commands, which will improve consistency with the instructions for other platforms like x86 and align with current Python packaging best practices.
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #26747 (comment), move the build.inc content into arm.inc page.
cc @hmellor