[BUGFIX][NIXL] quick fix for 'assert self.connector_worker is not None' in get_kv_connector_stats#26851
Merged
jikunshang merged 1 commit intovllm-project:mainfrom Oct 15, 2025
Merged
Conversation
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an AssertionError in get_kv_connector_stats within the NixlConnector. The error occurs when this method is called on a scheduler-side connector, where self.connector_worker is expected to be None. The change replaces the assertion with a conditional check, which is the right approach to handle this case gracefully. The fix is well-targeted and effectively resolves the bug.
jikunshang
approved these changes
Oct 15, 2025
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…e' in get_kv_connector_stats (vllm-project#26851) Signed-off-by: Chendi Xue <chendi.xue@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Propose a quick fix which occurs after #26046
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.