[Graph Partition] pass tests for decorator#26831
[Graph Partition] pass tests for decorator#26831ProExpertProg merged 6 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Boyuan Feng <boyuan@meta.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the test_ignore_torch_compile_decorator test to be parameterized, covering cases both with and without inductor graph partitioning. This is a good improvement for test coverage. However, I've found a potential logic error in how one of the expected counter values is determined. The value for expected_num_cudagraph_captured is hardcoded, which appears to be incorrect for one of the parameterized test cases. My review includes a suggestion to calculate this value dynamically to ensure the test is accurate and robust.
Signed-off-by: Boyuan Feng <boyuan@meta.com>
BoyuanFeng
changed the title
ProExpertProg
left a comment
ProExpertProg
left a comment
There was a problem hiding this comment.
LGTM, just a question about the comments
Signed-off-by: Boyuan Feng <boyuan@meta.com>
ProExpertProg
added
the
ready
Signed-off-by: Boyuan Feng <boyuan@meta.com>
ProExpertProg
left a comment
ProExpertProg
left a comment
There was a problem hiding this comment.
Seems like the merge was clean
Signed-off-by: ProExpertProg <lgovedic@redhat.com>
ProExpertProg
added this to the
vllm==v0.12.0/torch==2.9.0 compilation improvements milestone
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: Boyuan Feng <boyuan@meta.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com>
2 participants
simple fix to pass
test_ignore_torch_compile_decoratorandtest_conditional_compile_enable_ifwith inductor graph partition.