Skip to content

[Feature] default --extra-body param to disable thinking in vllm bench serve #26784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 5 commits into from
Oct 15, 2025
Merged

[Feature] default --extra-body param to disable thinking in vllm bench serve #26784

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fc8388
[Feature] default disable thinking in vllm bench serve
lengrongfu Oct 14, 2025
500bc66
add --extra-body pararm to cli
lengrongfu Oct 14, 2025
d4c9ecd
still call this sampling_params
lengrongfu Oct 14, 2025
12ceb67
still call this sampling_params
lengrongfu Oct 14, 2025
47be117
Merge branch 'main' into feat/opt-bench
chaunceyjiang Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions vllm/benchmarks/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,7 +1305,7 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:

# Collect the sampling parameters.
if task_type == TaskType.GENERATION:
sampling_params = {
extra_body = {
Comment thread
lengrongfu marked this conversation as resolved.
Outdated
k: v
for k, v in {
"top_p": args.top_p,
Expand All @@ -1320,15 +1320,20 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:
}

# Sampling parameters are only supported by openai-compatible backend.
if sampling_params and args.backend not in OPENAI_COMPATIBLE_BACKENDS:
if extra_body and args.backend not in OPENAI_COMPATIBLE_BACKENDS:
raise ValueError(
"Sampling parameters are only supported by openai-compatible backends."
)

if "temperature" not in sampling_params:
sampling_params["temperature"] = 0.0 # Default to greedy decoding.
if "temperature" not in extra_body:
extra_body["temperature"] = 0.0 # Default to greedy decoding.

# Default disable thinking
extra_body["chat_template_kwargs"] = {
"enable_thinking": False,
}
Comment thread
lengrongfu marked this conversation as resolved.
Outdated
else:
sampling_params = {}
extra_body = {}

# Avoid GC processing "static" data - reduce pause times.
gc.collect()
Expand All @@ -1355,7 +1360,7 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:
max_concurrency=args.max_concurrency,
lora_modules=args.lora_modules,
extra_headers=headers,
extra_body=sampling_params,
extra_body=extra_body,
ramp_up_strategy=args.ramp_up_strategy,
ramp_up_start_rps=args.ramp_up_start_rps,
ramp_up_end_rps=args.ramp_up_end_rps,
Expand Down