[Bugfix] Standardize merging multimodal embeddings#26771
[Bugfix] Standardize merging multimodal embeddings#26771DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request standardizes the merging of multimodal embeddings across various models. The changes involve renaming vision_embeddings to image_embeddings for better clarity and ensuring that embeddings are converted to a tuple before being concatenated. This improves code robustness by preventing potential TypeError exceptions when the underlying processing functions return lists instead of tuples. The changes are correct and improve the overall consistency and reliability of the codebase. No issues were found in this pull request.
|
这里没有对image_embeddings的类型和维度校验? 直接变tuple是否有测试各种情况下的兼容性 |
|
We check |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Purpose
Standardize how multimodal embeddings from different modalities are merged in
get_multimodal_embeddings:vision_embeddingstoimage_embeddingsto avoid confusing withvideo_embeddingsFIX #26749
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.