scheduler.py: Update the name of the default scheduler.#26758
scheduler.py: Update the name of the default scheduler.#26758DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request correctly updates the default scheduler class path in vllm/config/scheduler.py, which is a necessary fix to address an application startup failure. While the change is correct for the file modified, it has an unintended side effect in vllm/engine/arg_utils.py that could break configurations for users who explicitly specify the old scheduler path. I have left a detailed comment explaining the issue and a suggested fix. Addressing this backward compatibility issue would make this PR more complete.
Signed-off-by: Ryan Li <ryanli@ryanli.org>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org> Signed-off-by: bbartels <benjamin@bartels.dev>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org>
…#26758) Signed-off-by: Ryan Li <ryanli@ryanli.org>
Purpose
Rectify the name of the default scheduler which has been moved, fixing #26756.
Test Plan
To build an application directly using AsyncLLM using this updated build with default
SchedulerConfig.Test Result
The application starts successfully:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.