-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[CI/Build] Cleanup LoRA test #26752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Cleanup LoRA test #26752
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to clean up LoRA tests by removing redundant decorators and parameters. While most changes appear to be correct refactoring, I have identified a critical issue in tests/lora/test_mixtral.py where a change will cause a TypeError and break the test. Additionally, I've raised concerns about the removal of the @create_new_process_for_each_test decorator from single-GPU tests, which could potentially lead to test flakiness due to resource leakage.
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate why create_new_process_for_each_test can be removed?
See:https://github.com/vllm-project/vllm/blob/main/tests/utils.py#L1082 |
Signed-off-by: Jee Jee Li <[email protected]>
11a32c8 to
25de969
Compare
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: bbartels <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: 0xrushi <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]> Signed-off-by: 0xrushi <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.