- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.9k
[Model][Bugfix]fix ernie45 load failed due to ernie45 eplb code #26684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wangyafeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a critical bug that caused the ernie45 model to fail during loading when EPLB was disabled. The root cause, an incorrect access to a potentially None configuration value, is correctly fixed by using the eplb_config which provides a safe default. Furthermore, the changes to the MoE weight loading mechanism are a significant improvement, making it more robust for EPLB scenarios with redundant experts. By checking for loading success, the new logic correctly handles cases where an expert's weights might not be on a particular rank, allowing it to try other replicas. The implementation is clean and directly solves the reported issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry this got broken.
…-project#26684) Signed-off-by: wangyafeng <[email protected]> Signed-off-by: Dhruvil Bhatt <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]> Signed-off-by: bbartels <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]> Signed-off-by: 0xrushi <[email protected]>
…-project#26684) Signed-off-by: wangyafeng <[email protected]> Signed-off-by: 0xrushi <[email protected]>
Purpose
fix following issue by PR #22100
Test Plan
Running the following test script
python test_eplb.py --mode eplb
python test_eplb.py --mode normal
Test Result