Skip to content

[easy] fix pre commit error on trunk#26665

Merged
hmellor merged 1 commit intovllm-project:mainfrom
hl475:fix_pre_commit
Oct 12, 2025
Merged

[easy] fix pre commit error on trunk#26665
hmellor merged 1 commit intovllm-project:mainfrom
hl475:fix_pre_commit

Conversation

@hl475
Copy link
Copy Markdown
Contributor

@hl475 hl475 commented Oct 12, 2025

Purpose

pre-commit is failing on trunk (sample job https://github.com/vllm-project/vllm/actions/runs/18448162496/job/52557857653?pr=26663) with error msg

Error: vllm/model_executor/models/bert.py:612:23: F821 Undefined name `Optional`
Error: vllm/model_executor/models/bert.py:613:23: F821 Undefined name `Optional`

This PR fixes the issue by adopting Python 3.9 style

Test Plan

CI

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Huamin Li <3ericli@gmail.com>
@hl475 hl475 marked this pull request as ready for review October 12, 2025 19:11
@hmellor hmellor enabled auto-merge (squash) October 12, 2025 19:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 12, 2025
@hmellor hmellor merged commit 4fca1a1 into vllm-project:main Oct 12, 2025
57 checks passed
1994 pushed a commit to 1994/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: 1994 <1994@users.noreply.github.com>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants