[ResponseAPI] Simplify input/output message serialization#26620
Merged
yeqcharlotte merged 1 commit intovllm-project:mainfrom Oct 13, 2025
Merged
[ResponseAPI] Simplify input/output message serialization#26620yeqcharlotte merged 1 commit intovllm-project:mainfrom
yeqcharlotte merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Jialin
requested review from
DarkLight1337,
NickLucche,
aarnphm,
chaunceyjiang,
robertgshaw2-redhat and
simon-mo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the message serialization logic by extracting it into new utility functions, serialize_message and serialize_messages, which is a good improvement for code clarity and maintainability. However, I've identified a critical issue in the implementation of serialize_message that could lead to runtime errors and malformed JSON output. My review includes a detailed explanation and a suggested fix.
Collaborator
Author
5 tasks
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
github-actions
bot
added
the
ready
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
qandrew
reviewed
Oct 13, 2025
5 tasks
1994
pushed a commit
to 1994/vllm
that referenced
this pull request
Oct 14, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com> Signed-off-by: 1994 <1994@users.noreply.github.com>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…ct#26620) Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify #26185 by moving serialization into utils which could be applied to both input/output messages.
Test Plan & Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.