Skip to content

[BugFix] Fix a bug in counting running sequences#266

Merged
WoosukKwon merged 1 commit intomainfrom
fix-scheduler-bug
Jun 26, 2023
Merged

[BugFix] Fix a bug in counting running sequences#266
WoosukKwon merged 1 commit intomainfrom
fix-scheduler-bug

Conversation

@WoosukKwon
Copy link
Copy Markdown
Collaborator

Fixes #257

@WoosukKwon WoosukKwon requested a review from zhuohan123 June 26, 2023 19:37
Copy link
Copy Markdown
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@WoosukKwon WoosukKwon merged commit 526df28 into main Jun 26, 2023
@WoosukKwon WoosukKwon deleted the fix-scheduler-bug branch June 26, 2023 20:09
michaelfeil pushed a commit to michaelfeil/vllm that referenced this pull request Jul 1, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
see vllm-project#265

Signed-off-by: MengqingCao <cmq0113@163.com>
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
### What this PR does / why we need it?
Followup on vllm-project#266

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
yma11 pushed a commit to yma11/vllm that referenced this pull request Aug 19, 2025
Signed-off-by: chzhang <chaojun.zhang@intel.com>
yma11 pushed a commit to yma11/vllm that referenced this pull request Sep 1, 2025
Signed-off-by: chzhang <chaojun.zhang@intel.com>
mickg10 pushed a commit to mickg10/vllm that referenced this pull request Feb 11, 2026
* Pass logprobs

* Rename dict

* Fix linter

* Deactivate compat sampling

* Read logprobs

* Permute

* Rename param

* Assert for logprobs>1

* Fix linter

* Check if logprobs present

* Fix linter

* Rename flag

* Fix condition

* Assert for logprobs>1

* Fix attribute

* Discard dummy logprobs

* Fix bug

* Fix bug

* Fix linter

* Fix bug

* Fix bug

* Remove stale comment

* Nitpick

* Add comment

* Fix linter

* Rename

* Add comment

* Add logprobs warmup

* Refactor warmup

* Fix linter

* Fix assert

* Fix assert

* Add refactor comment

* Add single-device check

* Add single-device check

* Add single-device check

* Add comment

* Add comment

* Rename

* Fix linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On the way scheduler calculate the number of sequences

2 participants