Skip to content

Conversation

@yewentao256
Copy link
Member

@yewentao256 yewentao256 commented Oct 10, 2025

Purpose

Part of the #26533

Test

(wentao) wentao@dgxB200-09:~/vllm-source$ pre-commit run --hook-stage manual mypy-3.10 -a
Run mypy for Python 3.10.................................................Passed

Signed-off-by: yewentao256 <[email protected]>
@yewentao256 yewentao256 requested a review from hmellor as a code owner October 10, 2025 15:30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses potential NoneType errors in custom_all_reduce.py and symm_mem.py by adding checks for the return value of current_platform.get_device_capability(). This is a critical fix that improves the robustness of the distributed communicators, preventing crashes on platforms where device capability might not be available. The associated change in tools/pre_commit/mypy.py to enable stricter type checking for the vllm/distributed directory is a good practice that likely helped identify these issues. The changes are well-implemented and correct.

@hmellor
Copy link
Member

hmellor commented Oct 10, 2025

Looks like there are new followed imports that need resolving. You can run the CI version with pre-commit run --hook-stage manual mypy-3.10 -a

@hmellor hmellor changed the title [CI] Fix Distributed folder for mypy [CI] Fix mypy for vllm/distributed Oct 10, 2025
Signed-off-by: yewentao256 <[email protected]>
@mergify mergify bot added the kv-connector label Oct 10, 2025
@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 10, 2025
@yewentao256
Copy link
Member Author

@hmellor CC

Signed-off-by: Harry Mellor <[email protected]>
@hmellor
Copy link
Member

hmellor commented Oct 11, 2025

I made some tweaks which should make this area a bit more robust. Let's see if CI agrees

@mergify
Copy link

mergify bot commented Oct 13, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yewentao256.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 13, 2025
@mergify mergify bot removed the needs-rebase label Oct 13, 2025
@yewentao256 yewentao256 merged commit 314285d into main Oct 13, 2025
55 of 56 checks passed
@yewentao256 yewentao256 deleted the wentao-fix-distributed-mypy branch October 13, 2025 20:02
1994 pushed a commit to 1994/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: 1994 <[email protected]>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: Dhruvil Bhatt <[email protected]>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: bbartels <[email protected]>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: xuebwang-amd <[email protected]>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: 0xrushi <[email protected]>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Signed-off-by: 0xrushi <[email protected]>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Nov 12, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kv-connector ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants