[CI] Fix Pre-commit Issue Cannot determine type of "rank" and "world_size"

[yewentao256]

Purpose

Fix pre-commit issue

vllm/distributed/device_communicators/all2all.py:393: error: Cannot determine type of "rank"  [has-type]
vllm/distributed/device_communicators/all2all.py:394: error: Cannot determine type of "world_size"  [has-type]

[gemini-code-assist]

Code Review

This pull request fixes a mypy type checking error by adding redundant type annotations. While this is an effective workaround, it's important to address the underlying issue to improve code maintainability. My review includes a comment on this matter.

[mgoin]

@yewentao256 where is this precommit issue? Latest commits on main are passing fine

[yewentao256]

@yewentao256 where is this precommit issue? Latest commits on main are passing fine

@mgoin If you try to upload something diff with that file, this pre-commit issue will trigger locally

[hmellor]

Could you instead try moving vllm/distributed from SEPARATE_GROUPS to FILES:

vllm/tools/pre_commit/mypy.py

Lines 27 to 55 in 2e54db4

	FILES = [
	"vllm/*.py",
	"vllm/assets",
	"vllm/entrypoints",
	"vllm/inputs",
	"vllm/logging_utils",
	"vllm/multimodal",
	"vllm/platforms",
	"vllm/transformers_utils",
	"vllm/triton_utils",
	"vllm/usage",
	]
	# After fixing errors resulting from changing follow_imports
	# from "skip" to "silent", move the following directories to FILES
	SEPARATE_GROUPS = [
	"tests",
	"vllm/attention",
	"vllm/compilation",
	"vllm/distributed",
	"vllm/engine",
	"vllm/executor",
	"vllm/inputs",
	"vllm/lora",
	"vllm/model_executor",
	"vllm/plugins",
	"vllm/worker",
	"vllm/v1",
	]

There will probably be some other mypy errors but this will be better for the long term health of vLLM

[yewentao256]

@hmellor Thanks! There would be a lot of changes needed to solve the mypy issues within that folder, could we can make it in following-up issues/PRs?

#26533

[hmellor]

Ok I just tried and saw 47 issues. Many of them are likely linked to a few configs being marked as optional when they shouldn't be, so it likely won't require 47 changes.

But yes this can be follow up work. Please just add a comment saying that the duplicate type hinting can be removed once #26533 is closed?

[yewentao256]

@hmellor Done, thanks!