Skip to content

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Oct 8, 2025

Purpose

Related to #22862

Let's re-disable enforce_eager and check if the flaky test has been fixed.

  • If it has already been fixed, everyone is happy.
  • If it hasn't been fixed yet, error logs can help experts debug during the new release cycle.

The mteb test has been separated from Language Models Test in #24634, so the Nightly Test keeps failing, it won't confuse anyone.

cc @DarkLight1337 @robertgshaw2-redhat @zou3519

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to re-enable optimized code paths for certain tests by removing enforce_eager=True, with the goal of verifying a fix for a flaky test. The changes in tests/models/language/pooling_mteb_test/mteb_utils.py align perfectly with this objective. However, a similar change in tests/models/language/generation_ppl_test/ppl_utils.py seems out of scope and could potentially introduce instability in a different test suite. My review includes a comment highlighting this concern.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 8, 2025 11:08
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 8, 2025
@DarkLight1337 DarkLight1337 merged commit e39dc46 into vllm-project:main Oct 8, 2025
23 checks passed
@noooop noooop deleted the disable_enforce_eager branch October 8, 2025 12:58
mrasquinha-g pushed a commit to mrasquinha-g/vllm that referenced this pull request Oct 9, 2025
@noooop
Copy link
Collaborator Author

noooop commented Oct 10, 2025

https://buildkite.com/vllm/ci/builds/34315/steps/canvas?sid=0199cc47-93cd-48de-9a15-04250b1a3b55

[2025-10-10T04:42:04Z] FAILED models/language/pooling_mteb_test/test_bge_reranker_v2_gemma.py::test_rerank_models_mteb[model_info0] - RuntimeError: Engine core initialization failed. See root cause above. Failed core proc(s): {}
[2025-10-10T04:42:04Z] FAILED models/language/pooling_mteb_test/test_jina.py::test_embed_models_mteb[model_info0] - vllm.v1.engine.exceptions.EngineDeadError: EngineCore encountered an issue. See stack trace (above) for the root cause.
[2025-10-10T04:42:04Z] FAILED models/language/pooling_mteb_test/test_st_projector.py::test_embed_models_mteb[model_info1] - AssertionError

Can be reproduced locally

@Isotr0py Could you please help to do further investigation.

xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants