-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[Kernel] FA4 Integration. #26371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[Kernel] FA4 Integration. #26371
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
263f14a
init commit on fa4
zyongye 359b9cd
fix block size
zyongye d22f590
fix accuracy
zyongye 8500ae6
aviod copy output tensor
zyongye d41bac2
format
zyongye b0171df
revive output buffer
zyongye 6ee4444
.
zyongye 9f79055
cg work
zyongye 2d84b30
update fa_util
zyongye ddd610a
update sink constraint
zyongye a72a19b
Merge remote-tracking branch 'upstream/main' into fa4
zyongye 890a784
change alibi messages
zyongye 7170786
revert default selection of fa
zyongye eec021c
change dcp error message
zyongye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new branches rely on
VLLM_FLASH_ATTN_VERSION == 4to activate FA4-specific behavior, butget_flash_attn_versionstill asserts that the environment variable is only 2 or 3. SettingVLLM_FLASH_ATTN_VERSION=4to reach this code path currently triggers anAssertionErrorduring backend initialization, so the FA4 code here is unreachable and the feature cannot be enabled. The version-selection logic needs to be updated to admit 4 (and handle unsupported hardware) before these branches will ever execute.Useful? React with 👍 / 👎.