Fix per file ruff ignores related to line length#26262
Fix per file ruff ignores related to line length#26262DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Forward fixes the last of the issues skipped by vllm-project#26247 Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request addresses line length issues across the codebase by removing per-file ruff ignores for E501. The changes involve either reformatting long lines to comply with the line length limit or replacing file-level ignores with more specific line-level noqa comments. The modifications are extensive, touching many files in the benchmarks, csrc, examples, tests, and vllm directories. A significant change is the removal of a large block of E501 ignores from pyproject.toml. The approach taken is consistent and effectively resolves the widespread line length warnings. The code is now cleaner and the linting configuration is more maintainable. The changes that involve reformatting improve readability. While adding noqa comments is a pragmatic solution for lines that are difficult to reformat, the overall change is a positive step towards better code quality. I have reviewed the changes and found no issues of high or critical severity. The pull request is well-executed and achieves its goal.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Forward fixes the last of the issues skipped by #26247