Fix per file ruff ignores related to typing#26254
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Oct 5, 2025
Merged
Fix per file ruff ignores related to typing#26254DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
22quinn,
ApostaC,
DarkLight1337,
LucasWilkinson,
NickLucche,
WoosukKwon,
aarnphm,
alexm-redhat,
benchislett,
chaunceyjiang,
comaniac,
heheda12345,
mgoin,
njhill,
robertgshaw2-redhat,
russellb,
simon-mo,
youkaichao,
ywang96 and
zhuohan123
as code owners
mergify
bot
added
frontend
multi-modality
tests/plugins/prithvi_io_processor_plugin/prithvi_io_processor/prithvi_processor.py
Show resolved
Hide resolved
DarkLight1337
approved these changes
Oct 5, 2025
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
github-actions
bot
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request does a great job of cleaning up typing-related linting issues by removing many per-file ruff ignores and applying the corresponding fixes. The changes modernize the type hints, which improves code clarity and maintainability. However, I noticed that the modernization from Optional[X] to X | None (as per PEP 604) has been applied inconsistently across the codebase. Some files have been updated, while others that were part of this cleanup still use the older Optional syntax. To ensure consistency, I've added several suggestions to apply this modern typing style throughout the changed files. Addressing these will make the codebase more uniform and easier to maintain.
Member
Author
|
Gemini is wrong, the files where |
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan
pushed a commit
to karan/vllm
that referenced
this pull request
Oct 6, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward fixes some of the issues skipped by #26247