[Bugfix] Fix requirements paths in install instructions#25827
[Bugfix] Fix requirements paths in install instructions#25827simon-mo merged 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request aims to fix incorrect paths to requirements files. While the changes in the documentation file docs/getting_started/installation/cpu/s390x.inc.md are correct, the changes in docker/Dockerfile.ppc64le and docker/Dockerfile.s390x seem to introduce a build failure. These Dockerfiles build pyarrow from its source, and the requirements-build.txt file they refer to is from the arrow repository, not the vllm repository. The arrow repository does not have a requirements/ directory at the location where the command is run. I've left specific comments with suggestions to fix this.
…#25576) The installation docs referenced `requirements-build.txt` and `requirements-cpu.txt` but the actual file are located at `requirements/build.txt` and `requirements/cpu.txt`. This caused `pip install` commands to fail if followed literally. Updated all occurrences to use the correct path, assuming commands are run from the repository root. Signed-off-by: yingjun-mou <renzomou@gmail.com>
|
Hi @hmellor, could you please review this PR? Thanks. |
…#25827) Signed-off-by: yingjun-mou <renzomou@gmail.com>
Signed-off-by: yingjun-mou <renzomou@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…#25827) Signed-off-by: yingjun-mou <renzomou@gmail.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
…#25827) Signed-off-by: yingjun-mou <renzomou@gmail.com>
…#25827) Signed-off-by: yingjun-mou <renzomou@gmail.com>
…#25827) Signed-off-by: yingjun-mou <renzomou@gmail.com>
…#25827) Signed-off-by: yingjun-mou <renzomou@gmail.com>
Purpose
Updated all occurrences of wrong
requirements/paths to use the correct ones, assuming commands are run from the repository root.The installation docs referenced
requirements-build.txtandrequirements-cpu.txtbut the actual file are located atrequirements/build.txtandrequirements/cpu.txt. This causedpip installcommands to fail if followed literally.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.