Skip to content

[Bugfix] Fix requirements paths in install instructions#25827

Merged
simon-mo merged 1 commit intovllm-project:mainfrom
yingjun-mou:vllm
Sep 29, 2025
Merged

[Bugfix] Fix requirements paths in install instructions#25827
simon-mo merged 1 commit intovllm-project:mainfrom
yingjun-mou:vllm

Conversation

@yingjun-mou
Copy link
Contributor

@yingjun-mou yingjun-mou commented Sep 28, 2025

Purpose

Updated all occurrences of wrong requirements/ paths to use the correct ones, assuming commands are run from the repository root.

The installation docs referenced requirements-build.txt and requirements-cpu.txt but the actual file are located at requirements/build.txt and requirements/cpu.txt. This caused pip install commands to fail if followed literally.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 28, 2025
@yingjun-mou yingjun-mou changed the title [Bugfix] Fix requirements paths in install instructions #25576 [Bugfix] Fix requirements paths in install instructions Sep 28, 2025
@mergify mergify bot added the ci/build label Sep 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix incorrect paths to requirements files. While the changes in the documentation file docs/getting_started/installation/cpu/s390x.inc.md are correct, the changes in docker/Dockerfile.ppc64le and docker/Dockerfile.s390x seem to introduce a build failure. These Dockerfiles build pyarrow from its source, and the requirements-build.txt file they refer to is from the arrow repository, not the vllm repository. The arrow repository does not have a requirements/ directory at the location where the command is run. I've left specific comments with suggestions to fix this.

…#25576)

The installation docs referenced `requirements-build.txt` and `requirements-cpu.txt` but the
actual file are located at `requirements/build.txt` and `requirements/cpu.txt`. This caused
`pip install` commands to fail if followed literally.

Updated all occurrences to use the correct path, assuming commands
are run from the repository root.

Signed-off-by: yingjun-mou <renzomou@gmail.com>
@yingjun-mou
Copy link
Contributor Author

Hi @hmellor, could you please review this PR? Thanks.

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this

@simon-mo simon-mo merged commit edbaadd into vllm-project:main Sep 29, 2025
5 checks passed
pdasigi pushed a commit to pdasigi/vllm that referenced this pull request Oct 2, 2025
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: yingjun-mou <renzomou@gmail.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
…#25827)

Signed-off-by: yingjun-mou <renzomou@gmail.com>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants