[Bugfix] Fix Qwen3-VL regression from #24982#25814
[Bugfix] Fix Qwen3-VL regression from #24982#25814tlrmchlsmth merged 2 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request aims to fix a regression for Qwen3-VL by ensuring the text model configuration is used. The change replaces vllm_config.model_config.hf_config with vllm_config.model_config.hf_config.get_text_config(). While this fixes the issue for the multimodal Qwen3-VL model, it will likely cause a regression for the standalone Qwen3-MoE model, as the Hugging Face configuration for a non-multimodal model typically does not have a get_text_config() method, which would lead to an AttributeError. I've suggested a more robust fix in the comments, which is to use vllm_config.model_config.hf_text_config. This attribute is correctly populated by vLLM's ModelConfig to handle both multimodal and text-only models. This change should be applied to all instances, including the one in Qwen3MoeModel.__init__ which is not part of this PR's diff but contains the same pattern.
…t#25814) Signed-off-by: Roger Wang <hey@rogerw.io>
…t#25814) Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: Roger Wang <hey@rogerw.io> Signed-off-by: simon-mo <simon.mo@hey.com>
…t#25814) Signed-off-by: Roger Wang <hey@rogerw.io>
…t#25814) Signed-off-by: Roger Wang <hey@rogerw.io>
…t#25814) Signed-off-by: Roger Wang <hey@rogerw.io>
Purpose
#24982 caused a regression since the Qwen3-VL needs to access the text config of Qwen3-MoE via
get_text_config()Test Plan
Test Result
Tested locally to make sure both Qwen3-VL and Qwen3-MoE can load properly.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.