[CI] Fix test_shared_storage_connector_hashes#25748
[CI] Fix test_shared_storage_connector_hashes#25748DarkLight1337 merged 4 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request aims to fix a CI issue. It introduces a pytest fixture to ensure KV transfer groups are shut down after tests, preventing state leakage between modules. However, it also disables a test case for the 'ray' backend and hardcodes a user-specific model path, which will cause issues. My review focuses on making the test suite more robust and portable by addressing these two points.
NickLucche
left a comment
There was a problem hiding this comment.
Awesome job spotting this @chaunceyjiang !
Also tbh I don't have a strong opinion on this invariant https://github.com/vllm-project/vllm/blob/main/vllm/distributed/kv_transfer/kv_connector/v1/metrics.py#L54, it was just a quick way to prevent misuse.
We could also remove that line if this leads to unclear tests behavior or even worse if there are cases where VLLM_ENABLE_V1_MULTIPROCESSING=0 can be broken in a real scenario.. though I believe that should not be the case.
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
6e949af to
965fefd
Compare
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
|
Merging to unblock CI |
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Purpose
FIX #25745
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.