-
-
Notifications
You must be signed in to change notification settings - Fork 16k
[Harware][AMD][Model] Triton MoE tuning configs for GLM-4.5 for MI300X #25703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vllm-bot
merged 1 commit into
vllm-project:main
from
xaguilar-amd:glm-triton-moe-tuning-mi300x
Sep 26, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
164 changes: 164 additions & 0 deletions
164
.../layers/fused_moe/configs/E=160,N=384,device_name=AMD_Instinct_MI300X,dtype=fp8_w8a8.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| { | ||
| "1": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 64, | ||
| "BLOCK_SIZE_K": 256, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 8, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "2": { | ||
| "BLOCK_SIZE_M": 32, | ||
| "BLOCK_SIZE_N": 16, | ||
| "BLOCK_SIZE_K": 64, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "4": { | ||
| "BLOCK_SIZE_M": 64, | ||
| "BLOCK_SIZE_N": 128, | ||
| "BLOCK_SIZE_K": 256, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 4, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "8": { | ||
| "BLOCK_SIZE_M": 32, | ||
| "BLOCK_SIZE_N": 64, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "16": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 64, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 8, | ||
| "num_warps": 4, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "24": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 64, | ||
| "BLOCK_SIZE_K": 64, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "32": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 128, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 4, | ||
| "num_warps": 1, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "48": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 128, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "64": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 256, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 8, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "96": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 128, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 8, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "128": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 32, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "256": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 32, | ||
| "BLOCK_SIZE_K": 256, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "512": { | ||
| "BLOCK_SIZE_M": 32, | ||
| "BLOCK_SIZE_N": 64, | ||
| "BLOCK_SIZE_K": 256, | ||
| "GROUP_SIZE_M": 1, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "1024": { | ||
| "BLOCK_SIZE_M": 64, | ||
| "BLOCK_SIZE_N": 128, | ||
| "BLOCK_SIZE_K": 256, | ||
| "GROUP_SIZE_M": 8, | ||
| "num_warps": 4, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "1536": { | ||
| "BLOCK_SIZE_M": 128, | ||
| "BLOCK_SIZE_N": 256, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 8, | ||
| "num_warps": 8, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "2048": { | ||
| "BLOCK_SIZE_M": 128, | ||
| "BLOCK_SIZE_N": 256, | ||
| "BLOCK_SIZE_K": 64, | ||
| "GROUP_SIZE_M": 8, | ||
| "num_warps": 8, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "3072": { | ||
| "BLOCK_SIZE_M": 16, | ||
| "BLOCK_SIZE_N": 32, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 4, | ||
| "num_warps": 2, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| }, | ||
| "4096": { | ||
| "BLOCK_SIZE_M": 256, | ||
| "BLOCK_SIZE_N": 256, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 16, | ||
| "num_warps": 8, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 0 | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration for a batch size of 32 appears unusual, particularly when compared to the one for batch size 48, which uses identical block dimensions.
num_warps: 1: Using a single warp is often suboptimal as it limits parallelism and the ability to hide memory latency. For batch size 48,num_warpsis set to 2.GROUP_SIZE_M: 4: This enables grouping for better L2 cache reuse, which is generally more effective for larger batch sizes. However, for batch size 48, grouping is disabled (GROUP_SIZE_M: 1).This combination for batch size 32 is counter-intuitive and might be a typo, potentially leading to performance degradation. Could you please verify these parameters and provide benchmark data? I'd suggest aligning it with the configuration for batch size 48 if this was an oversight.