[mypy] Further improve MM type annotations#25654
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Sep 25, 2025
Merged
[mypy] Further improve MM type annotations#25654DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a series of valuable improvements to the multimodal type annotations, enhancing type safety and code clarity. The changes include refactoring for better readability, adding casts to guide mypy, using more specific type hints, and introducing a type-narrowing method. The addition of a json_map_leaves overload is a key change that simplifies code elsewhere. All these changes are well-executed and improve the overall quality of the codebase. I have not found any issues of high or critical severity.
Zhuul
pushed a commit
to Zhuul/vllm
that referenced
this pull request
Sep 26, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix more type checking issues
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.