Skip to content

[Bugfix][Core] fix KeyError in _update_waiting_for_remote_kv #25563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kebe7jun wants to merge 1 commit into from
Closed

[Bugfix][Core] fix KeyError in _update_waiting_for_remote_kv #25563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm/v1/core/sched/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,5 +1287,7 @@ def _update_from_kv_xfer_finished(self,
logger.debug("Finished recving KV transfer for request %s", req_id)
self.finished_recving_kv_req_ids.add(req_id)
for req_id in (kv_connector_output.finished_sending or ()):
if req_id not in self.requests:
Copy link
Contributor

@nicole-lihui nicole-lihui Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could also add the existence check for for req_id in (kv_connector_output.finished_recving or ()):

continue
logger.debug("Finished sending KV transfer for request %s", req_id)
self._free_blocks(self.requests[req_id])
Comment on lines +1290 to 1293
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The added check correctly prevents the KeyError if a request has been aborted and removed from self.requests. For a slight improvement in efficiency and conciseness, you could use dict.get() to perform the check and retrieval in a single operation. This avoids the double dictionary lookup (in followed by []).

Suggested change
if req_id not in self.requests:
continue
logger.debug("Finished sending KV transfer for request %s", req_id)
self._free_blocks(self.requests[req_id])
request = self.requests.get(req_id)
if request:
logger.debug("Finished sending KV transfer for request %s", req_id)
self._free_blocks(request)