[Model] Add optional parameter to reasoning parser constructor#25554
Merged
DarkLight1337 merged 5 commits intovllm-project:mainfrom Sep 25, 2025
Merged
Conversation
Signed-off-by: taohui <taohui3@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to add optional parameters to the ReasoningParser constructors to allow for more flexible behavior control. While the base class ReasoningParser is correctly updated to accept *args and **kwargs, all modified subclasses fail to forward these arguments in their super().__init__ calls. This oversight defeats the purpose of the change and will prevent the optional parameters from being passed up the inheritance chain. I've added comments with suggestions to fix this in each affected file. This is a critical issue that needs to be addressed for the feature to work as intended.
fix(parser): ensure subclasses forward *args and **kwargs to super().__init__ Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Tao Hui <taohui3@gmail.com>
…__init__ Signed-off-by: taohui <taohui3@gmail.com>
chaunceyjiang
approved these changes
Sep 25, 2025
Collaborator
chaunceyjiang
left a comment
chaunceyjiang
left a comment
There was a problem hiding this comment.
Thanks~
I believe this is a backward-compatible change.
chaunceyjiang
added
the
ready
Collaborator
|
/cc @aarnphm PTAL. |
Signed-off-by: taohui <taohui3@gmail.com>
taohui
force-pushed
the
deepseek_v3.1_reasoning_parser_add_request_param
branch
from
07bd3e2 to
b7cc0ec
Compare
Signed-off-by: taohui <taohui3@gmail.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: taohui <taohui3@gmail.com> Signed-off-by: Tao Hui <taohui3@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…project#25554) Signed-off-by: taohui <taohui3@gmail.com> Signed-off-by: Tao Hui <taohui3@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…project#25554) Signed-off-by: taohui <taohui3@gmail.com> Signed-off-by: Tao Hui <taohui3@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…project#25554) Signed-off-by: taohui <taohui3@gmail.com> Signed-off-by: Tao Hui <taohui3@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add an optional parameter to the reasoning parser constructor to allow
behavior control based on fields like 'thinking' in the request.
This PR is split from #24972.
For more details, please refer to the original PR.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.