[V0 Deprecation] Remove unused classes in attention #25541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
requested review from
LucasWilkinson,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat,
youkaichao,
ywang96 and
zhuohan123
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a great cleanup effort, removing a significant amount of deprecated V0 attention code. The changes are mostly correct and consistent. However, I found one critical issue in vllm/v1/attention/backends/pallas.py where the PallasAttentionBackend class fails to implement an abstract method from its base class, which will lead to a TypeError at runtime. Please see my comment for the details and a suggested fix.
| @staticmethod | ||
| def get_metadata_cls() -> type["PallasMetadata"]: | ||
| return PallasMetadata | ||
|
|
Contributor
There was a problem hiding this comment.
The abstract method get_builder_cls is defined in the base class AttentionBackend, but it's not implemented in PallasAttentionBackend. This will cause a TypeError when trying to instantiate PallasAttentionBackend. Since the Pallas backend does not use a metadata builder, you should add an implementation that raises NotImplementedError.
@staticmethod
def get_builder_cls():
raise NotImplementedError("Pallas backend does not use a metadata builder.")
zhuohan123
approved these changes
Sep 24, 2025
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
xuechendi
added a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
vllm-project/vllm#25541 --------- Signed-off-by: Chendi Xue <[email protected]>
skavulya
pushed a commit
to skavulya/vllm-gaudi
that referenced
this pull request
Sep 25, 2025
vllm-project/vllm#25541 --------- Signed-off-by: Chendi Xue <[email protected]> Signed-off-by: Kavulya, Soila P <[email protected]>
iboiko-habana
pushed a commit
to iboiko-habana/vllm-gaudi
that referenced
this pull request
Oct 2, 2025
vllm-project/vllm#25541 --------- Signed-off-by: Chendi Xue <[email protected]> Signed-off-by: Iryna Boiko <[email protected]>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: yewentao256 <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Woosuk Kwon <[email protected]>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Woosuk Kwon <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Woosuk Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.