Draft
Conversation
Signed-off-by: Giancarlo Delfin <gdelfin@meta.com>
Signed-off-by: Giancarlo Delfin <gdelfin@meta.com>
|
This pull request has merge conflicts that must be resolved before it can be |
|
I had to make a change for the drafter to use the tree, but it didn't seem to improve the performance |
TheEpicDolphin
force-pushed
the
test_tree_flash_attn
branch
2 times, most recently
from
3c94337 to
afd134b
Compare
TheEpicDolphin
force-pushed
the
test_tree_flash_attn
branch
from
afd134b to
7ea064d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmarks comparing standard vs tree spec decode with new FA2 + mask kernel: https://docs.google.com/spreadsheets/d/1imDQmv-5yPbDZwWRD7FslDUw5KQ794ET8RY7701jfmk/edit?usp=sharing