[docs] Prompt Embedding feature support#25288
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Sep 20, 2025
Merged
Conversation
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to add documentation for Prompt Embedding support in the v1 engine. However, my review found a critical contradiction. Other files in the codebase, including a test file and another documentation file, indicate that this feature is not yet supported in v1. This suggests the documentation update may be based on a false premise and could mislead users. I've added a critical comment to highlight this discrepancy.
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
DarkLight1337
approved these changes
Sep 20, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: yewentao256 <zhyanwentao@126.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#24278 officially enabled support for Prompt Embeddings in the v1 engine, and achieved feature parity with the implementation in the v0 engine. Since it's now available in both engines, I think it makes sense to add Prompt Embeds to the feature matrix in the docs so that it is clearly documented what features will and wont work with them.
Test Plan
N/A
Test Result
N/A
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.