[Fix] Keep scheduler.running as deque#2523
Merged
WoosukKwon merged 1 commit intovllm-project:mainfrom Jan 21, 2024
Merged
Conversation
vllm-project#2290 changed the scheduler seq group lists to be deques for more efficient updates, but missed one place where the `running` deque gets converted back to a list.
WoosukKwon
approved these changes
Jan 21, 2024
Collaborator
WoosukKwon
left a comment
WoosukKwon
left a comment
There was a problem hiding this comment.
LGTM. Thanks for submitting the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2290 changed the scheduler seq group lists to be deques for more efficient updates, but missed one place where the
runningdeque gets converted back to a list.