Skip to content

[env] default nixl side port conflicts with kv-event zmq port#25056

Merged
NickLucche merged 1 commit into
vllm-project:mainfrom
panpan0000:port5557
Sep 27, 2025
Merged

[env] default nixl side port conflicts with kv-event zmq port#25056
NickLucche merged 1 commit into
vllm-project:mainfrom
panpan0000:port5557

Conversation

@panpan0000
Copy link
Copy Markdown
Contributor

@panpan0000 panpan0000 commented Sep 17, 2025 •
edited by github-actions Bot
Loading

Purpose

Fix #25059

Test Plan

NA

Test Result

NA

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the default port for the NIXL side channel from 5557 to 5560 to resolve a conflict with the kv-event zmq port. The change is applied consistently to both the type-hinting section and the runtime environment variable definition. My review focuses on improving the maintainability of this configuration by addressing the duplicated magic number for the port, which could lead to future configuration issues.

Comment thread vllm/envs.py Outdated
Comment thread vllm/envs.py Outdated
@panpan0000 panpan0000 mentioned this pull request Sep 17, 2025
Closed
1 task
@panpan0000 panpan0000 mentioned this pull request Sep 18, 2025
Merged
@mergify mergify Bot added the kv-connector label Sep 18, 2025
@panpan0000
Copy link
Copy Markdown
Contributor Author

panpan0000 commented Sep 23, 2025 •
edited
Loading

@NickLucche can you kindly help to review this small PR, pls?

@panpan0000
Copy link
Copy Markdown
Contributor Author

panpan0000 commented Sep 25, 2025

@chaunceyjiang， PTAL

NickLucche
NickLucche reviewed Sep 25, 2025
View reviewed changes
Comment thread vllm/envs.py Outdated
NickLucche
NickLucche reviewed Sep 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also quickly check whether the old port is used in some example?

@panpan0000
Copy link
Copy Markdown
Contributor Author

panpan0000 commented Sep 26, 2025 •
edited
Loading

can you also quickly check whether the old port is used in some example?

Thank you @NickLucche

I checked and grep, seems no any other place to be fixed.

@panpan0000
[env] default nixl side port conflicts with kv-event zmq port
cde83d0 
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@NickLucche NickLucche enabled auto-merge (squash) September 27, 2025 13:36
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 27, 2025
@NickLucche NickLucche merged commit 49996cd into vllm-project:main Sep 27, 2025
50 checks passed
pdasigi pushed a commit to pdasigi/vllm that referenced this pull request Oct 2, 2025
@panpan0000 @pdasigi
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
c4b673c 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@panpan0000 @yewentao256
[env] default nixl side port conflicts with kv-event zmq port (#25056)
9b4c752 
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@panpan0000 @lywa1998
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
a609f12 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
@panpan0000 @alhridoy
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
09fc8e7 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
@panpan0000 @rtourgeman
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
949cb25 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
@panpan0000 @devpatelio
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
89213c8 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
This was referenced Jan 30, 2026
Merged
Merged
Merged
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
@panpan0000
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
bca5fc3 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@panpan0000
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
7e3f0f8 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@panpan0000 @yewentao256
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
bbb4aae 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@panpan0000
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
a8875cb 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@panpan0000 @yewentao256
[env] default nixl side port conflicts with kv-event zmq port (vllm-p…
adb73f4 
…roject#25056)

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLucche NickLucche NickLucche approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kv-connector ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: default nixl side channel port conflicts with kv-event zmq port

2 participants

@panpan0000 @NickLucche