Skip to content

[XPU] add missing dependency tblib for XPU CI #24639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jikunshang merged 3 commits into from
Sep 11, 2025
Merged

[XPU] add missing dependency tblib for XPU CI #24639

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16d3ef2
add tblib
faaany Sep 11, 2025
256420f
Merge branch 'vllm-project:main' into add_tblib
faaany Sep 11, 2025
ab962b6
Merge branch 'main' into add_tblib
faaany Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/scripts/hardware_ci/run-xpu-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ docker run \
bash -c '
set -e
echo $ZE_AFFINITY_MASK
pip install tblib==3.1.0
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For better dependency management and to ensure a consistent build environment, it's recommended to add this dependency to a requirements file instead of installing it directly in the CI script. This helps in centralizing dependency management and leverages Docker's layer caching, potentially speeding up the CI process.

Please consider adding tblib==3.1.0 to the appropriate requirements file (e.g., requirements/xpu.txt as used in docker/Dockerfile.xpu) and removing this line from the script.

Copy link
Copy Markdown
Contributor Author

@faaany faaany Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tblib is a test-only dependency. So adding to "xpu.txt" might not be appropriate. But adding an extra "xpu-test.txt" file is also unnecessary for just one dependency. So for now, I think install it directly in the CI script is the most straightforward way.

python3 examples/offline_inference/basic/generate.py --model facebook/opt-125m --block-size 64 --enforce-eager
python3 examples/offline_inference/basic/generate.py --model facebook/opt-125m --block-size 64 -O3 -O.cudagraph_mode=NONE
python3 examples/offline_inference/basic/generate.py --model facebook/opt-125m --block-size 64 --enforce-eager -tp 2 --distributed-executor-backend ray
Expand Down