[CI Failure] fix models/language/pooling/test_auto_prefix_cache_support.py #24636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noooop
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
noooop
force-pushed
the
fix_is_causal
branch
from
e0dea42 to
0cfa653
Compare
Signed-off-by: wang.yuqi <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a CI failure by adding a check to disable chunked prefill and prefix caching for non-causal pooling models. The change correctly identifies non-causal models by checking the is_causal attribute in the Hugging Face configuration and disables the features accordingly. The implementation is sound, placed appropriately within the pooling model configuration logic, and uses a safe default for the is_causal attribute. This is a good, targeted fix.
DarkLight1337
approved these changes
Sep 11, 2025
DarkLight1337
added
the
ready
Collaborator
Author
|
docs/readthedocs.org:vllm is stuck |
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…rt.py (vllm-project#24636) Signed-off-by: wang.yuqi <[email protected]>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
…rt.py (vllm-project#24636) Signed-off-by: wang.yuqi <[email protected]>
Merged
4 tasks
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…rt.py (vllm-project#24636) Signed-off-by: wang.yuqi <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…rt.py (vllm-project#24636) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…rt.py (vllm-project#24636) Signed-off-by: wang.yuqi <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CI Failure https://buildkite.com/vllm/ci/builds/30279/steps/canvas?sid=019936ef-408b-445b-866d-7ad2606ef35d
test_auto_prefix_cache_support is intentionally guard this feature.. LOL
Test Plan
models/language/pooling/test_auto_prefix_cache_support.py
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.