Closed
Conversation
Signed-off-by: zhewenli <zhewenli@meta.com>
Signed-off-by: zhewenli <zhewenli@meta.com>
Signed-off-by: zhewenli <zhewenli@meta.com>
Signed-off-by: zhewenli <zhewenli@meta.com>
zhewenl
force-pushed
the
test-cgf-dir
branch
from
72cc716 to
38ce6fa
Compare
izaitsevfb
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Sep 11, 2025
### Summary This PR adds an option to specify BC linter config path, which will be used in vllm-project/vllm#21234 ### Test plan Locally test against PR: vllm-project/vllm#24614 Before: ``` ../test-infra/tools/stronghold/bin/check-api-compatibility --base-commit=b5e383cd8b62975dec605bed05e22d273c296c7a --head-commit=38ce6fa81660f0be6e0e61672fdc499bcd7fabc4 ::group::fetch github.event.pull_request.base.sha From ssh://github.com/zhewenl/vllm * branch b5e383cd8b62975dec605bed05e22d273c296c7a -> FETCH_HEAD ::endgroup:: fatal: path 'vllm/_bc_linter.py' exists on disk, but not in 'b5e383cd8b62975dec605bed05e22d273c296c7a' ::warning file=vllm/v1/core/sched/output.py,line=99::Function CachedRequestData: num_computed_tokens changed from list[int] to list[float] ::warning file=vllm/v1/core/sched/scheduler.py,line=1::Function Scheduler.get_grammar_bitmask: function deleted ::warning file=vllm/v1/core/sched/scheduler.py,line=1::Function Scheduler.update_draft_token_ids: function deleted ``` After: ``` ../test-infra/tools/stronghold/bin/check-api-compatibility --base-commit=b5e383cd8b62975dec605bed05e22d273c296c7a --head-commit=38ce6fa81660f0be6e0e61672fdc499bcd7fabc4 --config-dir=.github ::group::fetch github.event.pull_request.base.sha From ssh://github.com/zhewenl/vllm * branch b5e383cd8b62975dec605bed05e22d273c296c7a -> FETCH_HEAD ::endgroup:: BC-linter: Using .bc-linter.yml (parsed successfully) fatal: path 'vllm/_bc_linter.py' exists on disk, but not in 'b5e383cd8b62975dec605bed05e22d273c296c7a' ::warning file=vllm/v1/core/sched/output.py,line=99::Function CachedRequestData: num_computed_tokens changed from list[int] to list[float] > ../test-infra/tools/stronghold/bin/check-api-compatibility --base-commit=b5e383cd8b62975dec605bed05e22d273c296c7a --head-commit=38ce6fa81660f0be6e0e61672fdc499bcd7fabc4 ``` Note the difference in `scheduler.py`, before the we specifying the local config the bc linter yml was not respected - so the default rules are applied and we check ALL python files; after specifying the yml the warnings are restricted to ONLY the functions with annotations
|
This pull request has merge conflicts that must be resolved before it can be |
zhewenl
force-pushed
the
test-cgf-dir
branch
from
2f556e6 to
7b92561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.