[Model] Enable BNB support for qwen2_5_omni_thinker#24420
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Sep 8, 2025
Merged
[Model] Enable BNB support for qwen2_5_omni_thinker#24420vllm-bot merged 2 commits intovllm-project:mainfrom
vllm-bot merged 2 commits intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables LoRA support for the qwen2_5_omni_thinker model, which is a prerequisite for bitsandbytes (BNB) quantization. The changes correctly add the SupportsLoRA interface, define the packed_modules_mapping for merged layers in both the language and vision components, and implement the get_mm_mapping method to identify the different parts of the multimodal model. These changes appear correct and necessary to fix the LoRA functionality that was removed in a previous refactoring. The implementation aligns well with vLLM's patterns for multimodal LoRA support. I have reviewed the code and found no issues.
Isotr0py
approved these changes
Sep 8, 2025
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
get_mm_mappingandSupportLoRA, deleted by Migrate Qwen2 inputs to TensorSchema #23475Test Plan
python examplexamples/offline_inference/vision_language.py \ --modality image \ --model-type qwen2_5_omniQwen/Qwen2.5-Omni-3B, with additional parameters: quantization="bitsandbytes" and enable_lora=TrueTest Result
I can generated the reasonable result on my local device:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.