[Docs] Remove Neuron install doc as backend no longer exists#24396
[Docs] Remove Neuron install doc as backend no longer exists#24396vllm-bot merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes documentation related to AWS Neuron, following its backend removal. The changes are mostly correct and achieve this goal. However, I noticed that the documentation for Intel Gaudi is also removed from the navigation, which seems out of scope and potentially unintentional. I've added a review comment with a suggestion to address this.
|
The in-tree intel doc doesn't exist anymore either and was left over from a previous removal. I removed it here while I was doing the same thing for Neuron. |
|
This pull request has merge conflicts that must be resolved before it can be |
simon-mo
left a comment
simon-mo
left a comment
There was a problem hiding this comment.
LGTM, We shouldn't give wrong impression if the code no longer works on the versioned release
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Will merge once pre-commit passes |
…oject#24396) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…oject#24396) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: bbartels <benjamin@bartels.dev>
…oject#24396) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…oject#24396) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
4 participants
Follow up for #21159
Removes install doc for Neuron now that the V0 backend no longer exists and the plugin has not yet been created.