Skip to content

[Misc] collect flashinfer version in collect_env.py#24378

Merged
houseroad merged 1 commit intovllm-project:mainfrom
yeqcharlotte:collect_flashinfer_version
Sep 7, 2025
Merged

[Misc] collect flashinfer version in collect_env.py#24378
houseroad merged 1 commit intovllm-project:mainfrom
yeqcharlotte:collect_flashinfer_version

Conversation

@yeqcharlotte
Copy link
Collaborator

@yeqcharlotte yeqcharlotte commented Sep 6, 2025

Purpose

While working on repro in yeqcharlotte#3, notice flashinfer version is not collected 😂

Test Plan

python vllm/collect_env.py 

Test Result

https://gist.github.com/yeqcharlotte/edbbf13b07a3e26e05ef14519641ca6e

...
==============================
Versions of relevant libraries
==============================
[pip3] efficientnet_pytorch==0.7.1
[pip3] flashinfer-python==0.3.1

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds flashinfer-python to the list of packages whose versions are collected by collect_env.py. The change is straightforward and correct, adding the package name to both DEFAULT_CONDA_PATTERNS and DEFAULT_PIP_PATTERNS. This will ensure the flashinfer version is included in the environment report, which is useful for debugging. The implementation is correct and I have no suggestions for improvement.

@zhuohan123 zhuohan123 enabled auto-merge (squash) September 6, 2025 21:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 6, 2025
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
auto-merge was automatically disabled September 7, 2025 01:20

Head branch was pushed to by a user without write access

@yeqcharlotte yeqcharlotte force-pushed the collect_flashinfer_version branch from 7b62cb7 to 502fc79 Compare September 7, 2025 01:20
@houseroad houseroad enabled auto-merge (squash) September 7, 2025 01:24
@houseroad houseroad merged commit 81c53ef into vllm-project:main Sep 7, 2025
38 checks passed
@yeqcharlotte yeqcharlotte deleted the collect_flashinfer_version branch September 7, 2025 07:43
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants