[Misc] collect flashinfer version in collect_env.py#24378
Merged
houseroad merged 1 commit intovllm-project:mainfrom Sep 7, 2025
Merged
[Misc] collect flashinfer version in collect_env.py#24378houseroad merged 1 commit intovllm-project:mainfrom
houseroad merged 1 commit intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds flashinfer-python to the list of packages whose versions are collected by collect_env.py. The change is straightforward and correct, adding the package name to both DEFAULT_CONDA_PATTERNS and DEFAULT_PIP_PATTERNS. This will ensure the flashinfer version is included in the environment report, which is useful for debugging. The implementation is correct and I have no suggestions for improvement.
zhuohan123
approved these changes
Sep 6, 2025
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
auto-merge was automatically disabled
September 7, 2025 01:20
Head branch was pushed to by a user without write access
7b62cb7 to
502fc79
Compare
houseroad
approved these changes
Sep 7, 2025
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Ye (Charlotte) Qi <yeq@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
While working on repro in yeqcharlotte#3, notice flashinfer version is not collected 😂
Test Plan
Test Result
https://gist.github.com/yeqcharlotte/edbbf13b07a3e26e05ef14519641ca6e
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.