Skip to content

[attention][DCP] use AttentionImpl.need_to_return_lse_for_decode#24372

Merged
youkaichao merged 4 commits intovllm-project:mainfrom
youkaichao:need_lse
Sep 7, 2025
Merged

[attention][DCP] use AttentionImpl.need_to_return_lse_for_decode#24372
youkaichao merged 4 commits intovllm-project:mainfrom
youkaichao:need_lse

Conversation

@youkaichao
Copy link
Member

@youkaichao youkaichao commented Sep 6, 2025

Purpose

Expose a new attribute to avoid hardcoded conditions.

Might be cleaner than #24369 ?

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
@mergify mergify bot added the v1 label Sep 6, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
Copy link
Member Author

hope the error message is clear enough:

DCP requires attention impls to return the softmax lse for decode, but the impl TritonMLAImpl does not return the softmax lse for decode.

Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao youkaichao marked this pull request as ready for review September 6, 2025 17:12
@youkaichao youkaichao enabled auto-merge (squash) September 6, 2025 23:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 6, 2025
@youkaichao youkaichao merged commit 558f090 into vllm-project:main Sep 7, 2025
48 checks passed
@youkaichao youkaichao deleted the need_lse branch September 7, 2025 02:12
minosfuture pushed a commit to minosfuture/vllm that referenced this pull request Sep 7, 2025
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants