[attention][DCP] use AttentionImpl.need_to_return_lse_for_decode#24372
Merged
youkaichao merged 4 commits intovllm-project:mainfrom Sep 7, 2025
Merged
[attention][DCP] use AttentionImpl.need_to_return_lse_for_decode#24372youkaichao merged 4 commits intovllm-project:mainfrom
youkaichao merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: youkaichao <youkaichao@gmail.com>
LucasWilkinson
approved these changes
Sep 6, 2025
Member
Author
|
hope the error message is clear enough:
|
Signed-off-by: youkaichao <youkaichao@gmail.com>
5 tasks
minosfuture
pushed a commit
to minosfuture/vllm
that referenced
this pull request
Sep 7, 2025
…m-project#24372) Signed-off-by: youkaichao <youkaichao@gmail.com>
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
…m-project#24372) Signed-off-by: youkaichao <youkaichao@gmail.com>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…m-project#24372) Signed-off-by: youkaichao <youkaichao@gmail.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…m-project#24372) Signed-off-by: youkaichao <youkaichao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Expose a new attribute to avoid hardcoded conditions.
Might be cleaner than #24369 ?
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.