Add @benchislett to codeowner for spec decode and structured outputs#24362
Merged
youkaichao merged 1 commit intovllm-project:mainfrom Sep 6, 2025
Merged
Add @benchislett to codeowner for spec decode and structured outputs#24362youkaichao merged 1 commit intovllm-project:mainfrom
youkaichao merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Benjamin Chislett <benjamin.chislett@centml.ai>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds @benchislett as a code owner for the speculative decoding and structured outputs features. The changes to the .github/CODEOWNERS file are correct and align with the intent of the pull request. I have no feedback as there are no critical or high-severity issues in this change.
ywang96
reviewed
Sep 6, 2025
Member
ywang96
left a comment
ywang96
left a comment
There was a problem hiding this comment.
Welcome! Will wait for @youkaichao to actually grant you write access from repo settings.
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
…llm-project#24362) Signed-off-by: Benjamin Chislett <benjamin.chislett@centml.ai>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…llm-project#24362) Signed-off-by: Benjamin Chislett <benjamin.chislett@centml.ai>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…llm-project#24362) Signed-off-by: Benjamin Chislett <benjamin.chislett@centml.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you @youkaichao for the invitation to join as a vLLM committer. I'm grateful for the opportunity to participate in the development of vLLM as a cutting-edge serving engine, and I am excited to help maintain the speculative decoding and structured outputs features.
Special thanks to @WoosukKwon @mgoin @LucasWilkinson @njhill @aarnphm @comaniac @alexm-redhat @DarkLight1337 @ywang96 @robertgshaw2-redhat @russellb from the vLLM community for very helpful code reviews and feedback.