[Fix] [gpt-oss] fix non-tool calling path for chat completion#24324
Merged
aarnphm merged 11 commits intovllm-project:mainfrom Sep 6, 2025
Merged
[Fix] [gpt-oss] fix non-tool calling path for chat completion#24324aarnphm merged 11 commits intovllm-project:mainfrom
aarnphm merged 11 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables tool usage by default for gpt-oss models, which is a helpful UX improvement. The implementation is mostly correct, but I've pointed out a small refactoring opportunity in serving_chat.py to improve code clarity by avoiding parameter reassignment. The removal of the duplicated self.use_harmony assignment is a good cleanup.
aarnphm
changed the title
nvpohanh
reviewed
Sep 5, 2025
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
aarnphm
requested review from
DarkLight1337 and
robertgshaw2-redhat
as code owners
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
github-actions
bot
added
the
ready
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Contributor
|
@elvischenv please check if this PR fixes #24301 , or do we also need #23440 ? Thanks! |
Contributor
|
It is working on main now. Thanks for the fix. |
5 tasks
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
dtrifiro
pushed a commit
to dtrifiro/vllm
that referenced
this pull request
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced for support tool calling when non-tool calling path was used