Skip to content

[Model] Add Support for Grok2#24286

Closed
wenchen76 wants to merge 2 commits intovllm-project:mainfrom
wenchen76:add-grok2
Closed

[Model] Add Support for Grok2#24286
wenchen76 wants to merge 2 commits intovllm-project:mainfrom
wenchen76:add-grok2

Conversation

@wenchen76
Copy link
Copy Markdown
Contributor

@wenchen76 wenchen76 commented Sep 5, 2025

Purpose

To address #23557

Test Plan

Test Result

This is a draft PR since the work is still in progress and the implementation currently produces incorrect results.

  • Tokenizer support:
    tokenizer.tok.json is currently not supported. As a workaround, you can use the Hugging Face–compatible tokenizer available here:

  • FlashAttention issue:
    I encountered the following error when testing:

RuntimeError: Worker failed with error 'This flash attention build does not support tanh softcapping.'

To work around this, I used flashinfer. I’m not sure if this error is specific to my environment.

  • Response correctness:
    The generated responses are still incorrect, I haven’t had the chance to fully debug this yet.

@igor-susic1 @BranZhai @Crucifixion-Fxl — It would be great if you could take a look and help out whenever you get the chance. Thanks so much! 🙏


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added documentation Improvements or additions to documentation new-model Requests to new models labels Sep 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 5, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wenchen76.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 5, 2025
@mergify mergify bot removed the needs-rebase label Sep 5, 2025
@njhill njhill changed the title Add Support for Grok2 [Model] Add Support for Grok2 Sep 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 9, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wenchen76.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 9, 2025
vermavis pushed a commit to vermavis/vllm that referenced this pull request Sep 19, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2025

Documentation preview: https://vllm--24286.org.readthedocs.build/en/24286/

@reaganjlee
Copy link
Copy Markdown
Contributor

Hey there, I'm curious on the status of this PR/if this description is still accurate?

@hmellor
Copy link
Copy Markdown
Member

hmellor commented Mar 6, 2026

Closing this PR as Grok-2 support has been fully implemented and merged via #31847

@hmellor hmellor closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-rebase new-model Requests to new models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants