Skip to content

Address Phi modeling update 2#2428

Merged
simon-mo merged 3 commits intovllm-project:mainfrom
huiwy:main
Jan 12, 2024
Merged

Address Phi modeling update 2#2428
simon-mo merged 3 commits intovllm-project:mainfrom
huiwy:main

Conversation

@huiwy
Copy link
Copy Markdown
Contributor

@huiwy huiwy commented Jan 12, 2024

Fixed variable name and weight name mismatch mentioned in #2383.

Copy link
Copy Markdown
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I have tested phi 1, 1.5, and 2.

curl http://localhost:8000/v1/completions \
    -H "Content-Type: application/json" \
    -d '{
        "model": "microsoft/phi-1_5",
        "prompt": "San Francisco is a",
        "max_tokens": 20,
        "temperature": 0
    }'
{"id":"cmpl-dc39c048711b453fb0e5e5930b0501a1","object":"text_completion","created":82988,"model":"microsoft/phi-1_5","choices":[{"index":0,"text":" city that has a lot of history and culture. It has a lot of buildings and monuments that tell","logprobs":null,"finish_reason":"length"}],"usage":{"prompt_tokens":4,"total_

(base) xmo@simon-devbox:~$ curl http://localhost:8000/v1/completions     -H "Content-Type: application/json"     -d '{
        "model": "microsoft/phi-2",
        "prompt": "San Francisco is a",
        "max_tokens": 20,
        "temperature": 0
    }'
{"id":"cmpl-0cca6c5891f64b1bb312553341c3505f","object":"text_completion","created":83037,"model":"microsoft/phi-2","choices":[{"index":0,"text":" city that is known for its diverse population and vibrant culture. However, it is also a city that","logprobs":null,"finish_reason":"length"}],"usage":{"prompt_tokens":4,"total_tokens":24,"completion_tokens":20}}

(base) xmo@simon-devbox:~$ curl http://loctent-Type: application/json"     -d '{t
        "model": "microsoft/phi-1",
        "prompt": "San Francisco is a",
        "max_tokens": 20,
        "temperature": 0
    }'
{"id":"cmpl-d218bd0bbcfc4b97bdb107382fb42281","object":"text_completion","created":83158,"model":"microsoft/phi-1","choices":[{"index":0,"text":" city located on the intersection of New York City and Los Angeles. It is located in the vicinity of","logprobs":null,"finish_reason":"length"}],"usage":{"prompt_tokens":4,"total_tokens":24,"completion_tokens":20}}(base) xmo@simon-devbox:~$

@simon-mo
Copy link
Copy Markdown
Collaborator

Please fix the formatting by running ./format.sh --all. It seems I can't directly push the change here because it's your main branch.

@simon-mo simon-mo merged commit 7878958 into vllm-project:main Jan 12, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jan 14, 2024
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Jan 18, 2024
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants