Skip to content

Fix ipv4 ipv6 dualstack #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-mo merged 2 commits into from
Jan 10, 2024
Merged

Fix ipv4 ipv6 dualstack #2408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c970cd1
Fix ipv4 ipv6 dualstack
yunfeng-scale Jan 10, 2024
02c77c7
yapf
yunfeng-scale Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vllm/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ def in_wsl() -> bool:


def get_ip() -> str:
return socket.gethostbyname(socket.gethostname())
s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
s.connect(("8.8.8.8", 80)) # Doesn't need to be reachable
Copy link
Copy Markdown
Collaborator

@simon-mo simon-mo Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happen if it is not reachable? will it timeout/error?

Copy link
Copy Markdown
Contributor Author

@yunfeng-scale yunfeng-scale Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried some other non-reachable addresses and this still works

return s.getsockname()[0]


def get_open_port() -> int:
Expand Down