Support using SigLIP2 text and image embedding as standalone model#24027
Support using SigLIP2 text and image embedding as standalone model#24027duc-ph wants to merge 11 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the SigLIP2 implementation to support using the text and image embedding models as standalone components. The changes are generally in the right direction, but there are several critical issues in the new text model implementation that will cause runtime errors. These include incorrect loop iteration, a method call with missing arguments, and an incorrect call to a superclass constructor. Additionally, there's a potential bug in how vision inputs are checked, which could lead to incorrect behavior for empty inputs. These issues need to be addressed before this PR can be merged.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
Signed-off-by: “DP” <you@example.com>
Signed-off-by: “DP” <you@example.com>
Signed-off-by: “DP” <you@example.com>
|
Closing this PR as the functionality has been superseded by merged work. PR #27324 added |
WIP