[BUGFIX ]'AttributeError: '_OpNamespace' '_C' object has no attribute 'silu_and_mul_nvfp4_quant' #23924
[BUGFIX ]'AttributeError: '_OpNamespace' '_C' object has no attribute 'silu_and_mul_nvfp4_quant' #23924JartX wants to merge 1 commit intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses a bug that causes a crash on ROCM platforms by adding a check for the existence of the silu_and_mul_nvfp4_quant operator before it's used. This operator is specific to NVIDIA hardware and not available on ROCM, so adding a hasattr check is the correct way to prevent an AttributeError during the compilation's FixFunctionalizationPass. The change is correct, minimal, and effectively resolves the reported issue, improving the codebase's cross-platform compatibility.
|
@elvischenv Please check this out if you're so kind :) |
|
@jeejeelee please check it, I think my solution could be improved by filtering directly by ROCM, but I would need to test it on AITER hardware, which I do not have. |
|
Thanks for reporting this. Previously #10867 added We may also need to exclude @SageMoore @ProExpertProg may have comments |
|
Good @elvischenv, thank you for the speed and cooperation, just checking if the attribute is available, and then calling the function |
|
This pull request has merge conflicts that must be resolved before it can be |
The PR fixes the bug introduced in PR: #23671 and reported in #23916 of inference in ROCM, it only checks if the attribute exists before calling the function